ALSA: hda - Fix hp-mic mode without VREF bits
authorTakashi Iwai <tiwai@suse.de>
Tue, 26 Nov 2013 07:44:26 +0000 (08:44 +0100)
committerTakashi Iwai <tiwai@suse.de>
Wed, 27 Nov 2013 13:55:45 +0000 (14:55 +0100)
When the hp mic pin has no VREF bits, the driver forgot to set PIN_IN
bit.  Spotted during debugging old MacBook Airs.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=65681
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/hda_generic.c

index 3bd89ab0d9af703f9130d94a5747cd8ad77431a2..faefff1d3e81eed9bfc4c5f9bf487b4d5413a692 100644 (file)
@@ -2760,7 +2760,7 @@ static int hp_mic_jack_mode_put(struct snd_kcontrol *kcontrol,
                        val &= ~(AC_PINCTL_VREFEN | PIN_HP);
                        val |= get_vref_idx(vref_caps, idx) | PIN_IN;
                } else
-                       val = snd_hda_get_default_vref(codec, nid);
+                       val = snd_hda_get_default_vref(codec, nid) | PIN_IN;
        }
        snd_hda_set_pin_ctl_cache(codec, nid, val);
        call_hp_automute(codec, NULL);