USB: ohci-jz4740: FEAT_POWER is a port feature, not a hub feature
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Mon, 14 Apr 2014 10:08:14 +0000 (12:08 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Apr 2014 20:59:41 +0000 (13:59 -0700)
Power control of hub ports target the CLEAR_FEATURE and SET_FEATURE
requests to ports, not to the hub. Fix the hub control function to
detect the request correctly.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/ohci-jz4740.c

index b34315ca6cffcef5dc443a61a1070ec7b2d9f073..c2c221a332eb481c907a0a4813b857f8162982d6 100644 (file)
@@ -85,11 +85,11 @@ static int ohci_jz4740_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
        int ret = 0;
 
        switch (typeReq) {
-       case SetHubFeature:
+       case SetPortFeature:
                if (wValue == USB_PORT_FEAT_POWER)
                        ret = ohci_jz4740_set_vbus_power(jz4740_ohci, true);
                break;
-       case ClearHubFeature:
+       case ClearPortFeature:
                if (wValue == USB_PORT_FEAT_POWER)
                        ret = ohci_jz4740_set_vbus_power(jz4740_ohci, false);
                break;