arch/powerpc/platforms/pseries/hotplug-memory.c: section removal cleanups
authorYasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Wed, 10 Oct 2012 22:53:53 +0000 (15:53 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 10 Oct 2012 23:50:14 +0000 (08:50 +0900)
Followups to d760afd4d257 ("memory-hotplug: suppress "Trying to free
nonexistent resource <XXXXXXXXXXXXXXXX-YYYYYYYYYYYYYYYY>" warning").

 - use unsigned long type, as overflows are conceivable

 - rename `i' to the less-misleading and more informative `section'

Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/powerpc/platforms/pseries/hotplug-memory.c

index 2fe690fcaa1d89367455e8cb4c13fc1b7c7028a0..ecdb0a6b317172f396a858d382c4a0946745943e 100644 (file)
@@ -77,8 +77,9 @@ static int pseries_remove_memblock(unsigned long base, unsigned int memblock_siz
 {
        unsigned long start, start_pfn;
        struct zone *zone;
-       int i, ret;
-       int sections_to_remove;
+       int ret;
+       unsigned long section;
+       unsigned long sections_to_remove;
 
        start_pfn = base >> PAGE_SHIFT;
 
@@ -99,8 +100,8 @@ static int pseries_remove_memblock(unsigned long base, unsigned int memblock_siz
         * while writing to it. So we have to defer it to here.
         */
        sections_to_remove = (memblock_size >> PAGE_SHIFT) / PAGES_PER_SECTION;
-       for (i = 0; i < sections_to_remove; i++) {
-               unsigned long pfn = start_pfn + i * PAGES_PER_SECTION;
+       for (section = 0; section < sections_to_remove; section++) {
+               unsigned long pfn = start_pfn + section * PAGES_PER_SECTION;
                ret = __remove_pages(zone, pfn, PAGES_PER_SECTION);
                if (ret)
                        return ret;