wl1271: Improve command polling
authorJuuso Oikarinen <juuso.oikarinen@nokia.com>
Wed, 28 Apr 2010 06:49:59 +0000 (09:49 +0300)
committerJohn W. Linville <linville@tuxdriver.com>
Wed, 28 Apr 2010 20:50:25 +0000 (16:50 -0400)
In testing I noticed that the wl1271 commands fall into two categories. In the
first category are "fast" commands, these mostly take only 0 or 1 polls to
complete, but occasionally upto 50 (giving a 0.5ms execution time.) In the
second category, the command completion takes well more than 0.5ms (from
1.5ms upwards.)

This patch fixes command polling such that it is optimal for the fast commands,
but also allows sleep for the longer ones.

Signed-off-by: Juuso Oikarinen <juuso.oikarinen@nokia.com>
Reviewed-by: Luciano Coelho <luciano.coelho@nokia.com>
Signed-off-by: Luciano Coelho <luciano.coelho@nokia.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/wl12xx/wl1271_cmd.c

index b19090334bc00bd68691b7a40a7c4bae6f0b2e8e..564526d812797c9287261077bab7e3556d0e7a73 100644 (file)
@@ -36,7 +36,7 @@
 #include "wl1271_cmd.h"
 #include "wl1271_event.h"
 
-#define WL1271_CMD_POLL_COUNT       5
+#define WL1271_CMD_FAST_POLL_COUNT       50
 
 /*
  * send command to firmware
@@ -76,11 +76,11 @@ int wl1271_cmd_send(struct wl1271 *wl, u16 id, void *buf, size_t len,
                        goto out;
                }
 
-               udelay(10);
                poll_count++;
-               if (poll_count == WL1271_CMD_POLL_COUNT)
-                       wl1271_info("cmd polling took over %d cycles",
-                                   poll_count);
+               if (poll_count < WL1271_CMD_FAST_POLL_COUNT)
+                       udelay(10);
+               else
+                       msleep(1);
 
                intr = wl1271_read32(wl, ACX_REG_INTERRUPT_NO_CLEAR);
        }