mlx5: ensure 0 is returned when vport is zero
authorColin Ian King <colin.king@canonical.com>
Fri, 18 Aug 2017 13:49:25 +0000 (14:49 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 18 Aug 2017 23:28:40 +0000 (16:28 -0700)
Currently, if vport is zero then then an uninialized return status
in err is returned.  Since the only return status at the end of the
function esw_add_uc_addr is zero for the current set of return paths
we may as well just return 0 rather than err to fix this issue.

Detected by CoverityScan, CID#1452698 ("Uninitialized scalar variable")

Fixes: eeb66cdb6826 ("net/mlx5: Separate between E-Switch and MPFS")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx5/core/eswitch.c

index fd51f0ea8df97dffbe013dfaf5a0c73de02bac70..6b84c111330197ab4982967fbdd8d84578de97c2 100644 (file)
@@ -401,7 +401,7 @@ fdb_add:
        esw_debug(esw->dev, "\tADDED UC MAC: vport[%d] %pM fr(%p)\n",
                  vport, mac, vaddr->flow_rule);
 
-       return err;
+       return 0;
 }
 
 static int esw_del_uc_addr(struct mlx5_eswitch *esw, struct vport_addr *vaddr)