f2fs: prevent checkpoint during roll-forward
authorJaegeuk Kim <jaegeuk@kernel.org>
Wed, 13 Aug 2014 23:30:46 +0000 (16:30 -0700)
committerJaegeuk Kim <jaegeuk@kernel.org>
Thu, 21 Aug 2014 20:57:00 +0000 (13:57 -0700)
Any checkpoint should not be done during the core roll-forward procedure.
Especially, it includes error cases too.

Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/recovery.c

index 7ca7aadaa6078cb80cc49bae6bb4143dfb905b62..d36ef35353b23833d35abf6fec4c3c8f19fc1795 100644 (file)
@@ -459,6 +459,9 @@ int recover_fsync_data(struct f2fs_sb_info *sbi)
        /* step #1: find fsynced inode numbers */
        sbi->por_doing = true;
 
+       /* prevent checkpoint */
+       mutex_lock(&sbi->cp_mutex);
+
        blkaddr = NEXT_FREE_BLKADDR(sbi, curseg);
 
        err = find_fsync_dnodes(sbi, &inode_list);
@@ -490,8 +493,13 @@ out:
                /* Flush all the NAT/SIT pages */
                while (get_pages(sbi, F2FS_DIRTY_META))
                        sync_meta_pages(sbi, META, LONG_MAX);
+               set_ckpt_flags(sbi->ckpt, CP_ERROR_FLAG);
+               mutex_unlock(&sbi->cp_mutex);
        } else if (need_writecp) {
+               mutex_unlock(&sbi->cp_mutex);
                write_checkpoint(sbi, false);
+       } else {
+               mutex_unlock(&sbi->cp_mutex);
        }
        return err;
 }