staging: cxt1e1: remove redundant memset() call
authorDaeseok Youn <daeseok.youn@gmail.com>
Sun, 9 Mar 2014 23:56:55 +0000 (08:56 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Mar 2014 21:22:47 +0000 (14:22 -0700)
The name array doens't need to set to 0. Because
sprintf/snprintf adds a terminating '\0'.

And also it doesn't need to assign name array
address to np pointer.

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/cxt1e1/linux.c

index b2a06cafa63e55e37abce5bdf910458757b5891e..58fe0fe5228ac51cac48c1ae3588c82e82710bf6 100644 (file)
@@ -214,15 +214,13 @@ status_t
 c4_wq_port_init(mpi_t *pi)
 {
 
-       char        name[16], *np;  /* NOTE: name of the queue limited by system
+       char        name[16];  /* NOTE: name of the queue limited by system
                                     * to 10 characters */
-
        if (pi->wq_port)
                return 0;                   /* already initialized */
 
-       np = name;
-       memset(name, 0, 16);
-       sprintf(np, "%s%d", pi->up->devname, pi->portnum); /* IE pmcc4-01) */
+       /* IE pmcc4-01 */
+       snprintf(name, sizeof(name), "%s%d", pi->up->devname, pi->portnum);
 
 #ifdef RLD_RESTART_DEBUG
        pr_info(">> %s: creating workqueue <%s> for Port %d.\n",