drm: Remove warning from drm_connector_unregister_all()
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Wed, 20 Apr 2016 22:21:14 +0000 (01:21 +0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 21 Apr 2016 07:17:24 +0000 (09:17 +0200)
Commit 6c87e5c3ec6d ("drm: Rename drm_connector_unplug_all() to
drm_connector_unregister_all()") replaced a manual connectors list walk
in drm_connector_unregister_all() with drm_for_each_connector(). The
list was walked without the mode config mutex locked as that ends up in
a clash with sysfs, but drm_connector_unregister_all() warns when the
mutex isn't locked.

The problem is known and doesn't require a large warning every time
drm_connector_unregister_all() is called. Fix it by reverting to manual
list walk.

Fixes: 6c87e5c3ec6d ("drm: Rename drm_connector_unplug_all() to drm_connector_unregister_all()")
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1461190874-32674-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com
drivers/gpu/drm/drm_crtc.c

index ee549a30bff15ceddeb7f755a3d00869ef25d69c..edcf12c5521d2e0433c6bc51c1a05fc81a0f2932 100644 (file)
@@ -1122,7 +1122,7 @@ void drm_connector_unregister_all(struct drm_device *dev)
        struct drm_connector *connector;
 
        /* FIXME: taking the mode config mutex ends up in a clash with sysfs */
-       drm_for_each_connector(connector, dev)
+       list_for_each_entry(connector, &dev->mode_config.connector_list, head)
                drm_connector_unregister(connector);
 }
 EXPORT_SYMBOL(drm_connector_unregister_all);