gen_stats: Stop using NLA_PUT*().

These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.

Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/core/gen_stats.c b/net/core/gen_stats.c
index 0452eb27a2724dcd3782f5acb15be04e7efba47e..ddedf211e588146f17eb2e147307d04991720170 100644 (file)
--- a/net/core/gen_stats.c
+++ b/net/core/gen_stats.c
@@ -27,7 +27,8 @@
 static inline int
 gnet_stats_copy(struct gnet_dump *d, int type, void *buf, int size)
 {
-       NLA_PUT(d->skb, type, size, buf);
+       if (nla_put(d->skb, type, size, buf))
+               goto nla_put_failure;
        return 0;
 
 nla_put_failure: