KVM: PPC: Fix machine checks on 32-bit Book3S
authorPaul Mackerras <paulus@samba.org>
Wed, 29 Jun 2011 00:16:42 +0000 (00:16 +0000)
committerAvi Kivity <avi@redhat.com>
Tue, 12 Jul 2011 10:16:45 +0000 (13:16 +0300)
Commit 69acc0d3ba ("KVM: PPC: Resolve real-mode handlers through
function exports") resulted in vcpu->arch.trampoline_lowmem and
vcpu->arch.trampoline_enter ending up with kernel virtual addresses
rather than physical addresses.  This is OK on 64-bit Book3S machines,
which ignore the top 4 bits of the effective address in real mode,
but on 32-bit Book3S machines, accessing these addresses in real mode
causes machine check interrupts, as the hardware uses the whole
effective address as the physical address in real mode.

This fixes the problem by using __pa() to convert these addresses
to physical addresses.

Signed-off-by: Paul Mackerras <paulus@samba.org>
Signed-off-by: Alexander Graf <agraf@suse.de>
arch/powerpc/kvm/book3s.c

index 73fdab8a567feb41423fa7527f58a8579dcd5bcf..83500fb62c83c3622d97ff7da14419828080d2fe 100644 (file)
@@ -28,6 +28,7 @@
 #include <asm/kvm_ppc.h>
 #include <asm/kvm_book3s.h>
 #include <asm/mmu_context.h>
+#include <asm/page.h>
 #include <linux/gfp.h>
 #include <linux/sched.h>
 #include <linux/vmalloc.h>
@@ -1342,8 +1343,8 @@ struct kvm_vcpu *kvmppc_core_vcpu_create(struct kvm *kvm, unsigned int id)
        vcpu_book3s->slb_nr = 64;
 
        /* remember where some real-mode handlers are */
-       vcpu->arch.trampoline_lowmem = (ulong)kvmppc_handler_lowmem_trampoline;
-       vcpu->arch.trampoline_enter = (ulong)kvmppc_handler_trampoline_enter;
+       vcpu->arch.trampoline_lowmem = __pa(kvmppc_handler_lowmem_trampoline);
+       vcpu->arch.trampoline_enter = __pa(kvmppc_handler_trampoline_enter);
        vcpu->arch.highmem_handler = (ulong)kvmppc_handler_highmem;
 #ifdef CONFIG_PPC_BOOK3S_64
        vcpu->arch.rmcall = *(ulong*)kvmppc_rmcall;