rtl8xxxu: Print a warning if flushing the FIFO fails
authorJes Sorensen <Jes.Sorensen@redhat.com>
Mon, 29 Feb 2016 22:05:49 +0000 (17:05 -0500)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 10 Mar 2016 13:29:20 +0000 (15:29 +0200)
Only print a warning if the FIFO flush fails, as opposed to printing
the status unconditionally.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c

index e444e2b91f40e1d9bf913d597b24a0877999efc0..5c08db745d0f50f3e422fcde523f96773b787299 100644 (file)
@@ -5689,6 +5689,7 @@ static int rtl8xxxu_emu_to_disabled(struct rtl8xxxu_priv *priv)
 
 static int rtl8xxxu_flush_fifo(struct rtl8xxxu_priv *priv)
 {
+       struct device *dev = &priv->udev->dev;
        u32 val32;
        int retry, retval;
 
@@ -5712,7 +5713,9 @@ static int rtl8xxxu_flush_fifo(struct rtl8xxxu_priv *priv)
        rtl8xxxu_write16(priv, REG_RQPN_NPQ, 0);
        rtl8xxxu_write32(priv, REG_RQPN, 0x80000000);
        mdelay(2);
-       pr_info("%s: retry %i\n", __func__, retry);
+
+       if (!retry)
+               dev_warn(dev, "Failed to flush FIFO\n");
 
        return retval;
 }