[media] vb2: include lengths in dmabuf qbuf debug message
authorJavier Martinez Canillas <javier@osg.samsung.com>
Wed, 20 Jul 2016 16:07:55 +0000 (13:07 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 24 Aug 2016 13:08:32 +0000 (10:08 -0300)
If the VIDIOC_QBUF ioctl fails due a wrong dmabuf length, it's
useful to get the invalid and minimum lengths as a debug info.

Before this patch:

vb2-core: __qbuf_dmabuf: invalid dmabuf length for plane 1

After this patch:

vb2-core: __qbuf_dmabuf: invalid dmabuf length 221248 for plane 1, minimum length 410880

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/v4l2-core/videobuf2-core.c

index ca8ffeb56d727b5f7af94910ee834a6329a05041..3d595186309ad95b73232080986d164d5b681206 100644 (file)
@@ -1228,8 +1228,10 @@ static int __qbuf_dmabuf(struct vb2_buffer *vb, const void *pb)
                        planes[plane].length = dbuf->size;
 
                if (planes[plane].length < vb->planes[plane].min_length) {
-                       dprintk(1, "invalid dmabuf length for plane %d\n",
-                               plane);
+                       dprintk(1, "invalid dmabuf length %u for plane %d, "
+                               "minimum length %u\n",
+                               planes[plane].length, plane,
+                               vb->planes[plane].min_length);
                        dma_buf_put(dbuf);
                        ret = -EINVAL;
                        goto err;