iwm3200wifi: remove comparison to WIFI_IF_NTFY_MAX in iwm_ntf_wifi_if_wrapper

drivers/net/wireless/iwmc3200wifi/rx.c: In function 'iwm_ntf_wifi_if_wrapper':
drivers/net/wireless/iwmc3200wifi/rx.c:1198: warning: comparison is always true due to limited range of data type

This is, of course, because the value of WIFI_IF_NTFY_MAX is 0xff and
hdr->oid is a u8.  This is obviously an attempt to verify the range on
an input value, but since it has no effect it can simply be removed.

Signed-off-by: John W. Linville <linville@tuxdriver.com>
Acked-by: Samuel Ortiz <samuel.ortiz@intel.com>

diff --git a/drivers/net/wireless/iwmc3200wifi/rx.c b/drivers/net/wireless/iwmc3200wifi/rx.c
index c02fcedea9fafc5e80375832d9e8bc7c70867317..a944893ae3ca78d9b3371102ffc85ad9b5cea65e 100644 (file)
--- a/drivers/net/wireless/iwmc3200wifi/rx.c
+++ b/drivers/net/wireless/iwmc3200wifi/rx.c
@@ -1195,11 +1195,8 @@ static int iwm_ntf_wifi_if_wrapper(struct iwm_priv *iwm, u8 *buf,
        IWM_DBG_NTF(iwm, DBG, "WIFI_IF_WRAPPER cmd is delivered to UMAC: "
                    "oid is 0x%x\n", hdr->oid);
 
-       if (hdr->oid <= WIFI_IF_NTFY_MAX) {
-               set_bit(hdr->oid, &iwm->wifi_ntfy[0]);
-               wake_up_interruptible(&iwm->wifi_ntfy_queue);
-       } else
-               return -EINVAL;
+       set_bit(hdr->oid, &iwm->wifi_ntfy[0]);
+       wake_up_interruptible(&iwm->wifi_ntfy_queue);
 
        switch (hdr->oid) {
        case UMAC_WIFI_IF_CMD_SET_PROFILE: