drivers/net/typhoon.c: delete double assignment
authorJulia Lawall <julia@diku.dk>
Tue, 26 Oct 2010 00:25:36 +0000 (00:25 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 27 Oct 2010 19:23:20 +0000 (12:23 -0700)
Delete successive assignments to the same location.  The current definition
does not initialize the respRing structure, which has the same type as the
cmdRing structure, so initialize that one instead.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression i;
@@

*i = ...;
 i = ...;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: David Dillow <dave@thedillows.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/typhoon.c

index b550da008a03fdfac1521555b42211fb195d0085..5b83c3f35f47c3421a518aaa04fb39224dac2ed3 100644 (file)
@@ -1300,7 +1300,7 @@ typhoon_init_rings(struct typhoon *tp)
        tp->rxHiRing.lastWrite = 0;
        tp->rxBuffRing.lastWrite = 0;
        tp->cmdRing.lastWrite = 0;
-       tp->cmdRing.lastWrite = 0;
+       tp->respRing.lastWrite = 0;
 
        tp->txLoRing.lastRead = 0;
        tp->txHiRing.lastRead = 0;