zd1211rw: Replace ZD_CS_MULTICAST with ZD_CS_NO_ACK
authorGábor Stefanik <netrolller.3d@gmail.com>
Thu, 14 May 2009 17:34:59 +0000 (17:34 +0000)
committerJohn W. Linville <linville@tuxdriver.com>
Wed, 20 May 2009 18:46:24 +0000 (14:46 -0400)
According to my tests, all that ZD_CS_MULTICAST does is to
disable retrying/waiting for an ACK. Reflect this by renaming
the bit to ZD_CS_NO_ACK and setting it based on
IEEE80211_TX_CTL_NO_ACK, instead of is_multicast_ether_addr.

Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/zd1211rw/zd_mac.c
drivers/net/wireless/zd1211rw/zd_mac.h

index 6bdb1704083b9b18dac4d414888625cc63bf0131..40b07b988224a4eee002a91c970fe1b5500f8ce2 100644 (file)
@@ -420,9 +420,9 @@ static void cs_set_control(struct zd_mac *mac, struct zd_ctrlset *cs,
        if (info->flags & IEEE80211_TX_CTL_FIRST_FRAGMENT)
                cs->control |= ZD_CS_NEED_RANDOM_BACKOFF;
 
-       /* Multicast */
-       if (is_multicast_ether_addr(header->addr1))
-               cs->control |= ZD_CS_MULTICAST;
+       /* No ACK expected (multicast, etc.) */
+       if (info->flags & IEEE80211_TX_CTL_NO_ACK)
+               cs->control |= ZD_CS_NO_ACK;
 
        /* PS-POLL */
        if (ieee80211_is_pspoll(header->frame_control))
index 4c05d3ee4c37a1c84bcc88098edf0c077eef41d8..7c2759118d13377afd5431b4f770567a3c24553a 100644 (file)
@@ -87,7 +87,7 @@ struct zd_ctrlset {
 
 /* zd_ctrlset control field */
 #define ZD_CS_NEED_RANDOM_BACKOFF      0x01
-#define ZD_CS_MULTICAST                        0x02
+#define ZD_CS_NO_ACK                   0x02
 
 #define ZD_CS_FRAME_TYPE_MASK          0x0c
 #define ZD_CS_DATA_FRAME               0x00