net: hns3: Fixes the initialization of MAC address in hardware
authorLipeng <lipeng321@huawei.com>
Tue, 19 Sep 2017 16:17:13 +0000 (17:17 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 19 Sep 2017 23:06:49 +0000 (16:06 -0700)
This patch fixes the initialization of MAC address, fetched from HNS3
firmware i.e. when it is not randomly generated, to the HNS3 hardware.

Fixes: ca60906d2795 ("net: hns3: Add support of HNS3 Ethernet Driver for
hip08 SoC")
Signed-off-by: Lipeng <lipeng321@huawei.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c

index 1c3e29447891644f48214aee3edceb9efd0ba1ef..4d68d6ea5143e3803945bf7d61adc32bb3498398 100644 (file)
@@ -2705,10 +2705,11 @@ static void hns3_init_mac_addr(struct net_device *netdev)
                eth_hw_addr_random(netdev);
                dev_warn(priv->dev, "using random MAC address %pM\n",
                         netdev->dev_addr);
-               /* Also copy this new MAC address into hdev */
-               if (h->ae_algo->ops->set_mac_addr)
-                       h->ae_algo->ops->set_mac_addr(h, netdev->dev_addr);
        }
+
+       if (h->ae_algo->ops->set_mac_addr)
+               h->ae_algo->ops->set_mac_addr(h, netdev->dev_addr);
+
 }
 
 static void hns3_nic_set_priv_ops(struct net_device *netdev)