usb: dwc3: fix the glue drivers using the nop phy
authorHeikki Krogerus <heikki.krogerus@linux.intel.com>
Wed, 18 Dec 2013 14:41:25 +0000 (16:41 +0200)
committerFelipe Balbi <balbi@ti.com>
Thu, 19 Dec 2013 15:27:41 +0000 (09:27 -0600)
The reset_gpio member of the usb_phy_gen_xceiv_platform_data
structure needs the have negative value or phy-generic's
probe will fail unless DT is used. 0 is a valid gpio number.

This fixes an issue where phy-generic fails to probe with
message: "usb_phy_gen_xceiv.0: Error requesting RESET GPIO 0".

Cc: <stable@vger.kernel.org>
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/dwc3/dwc3-exynos.c
drivers/usb/dwc3/dwc3-pci.c

index 8b20c70d91e788c8e27791b98e454c4a5ba87ae7..28c8ad79f5e6c578da4f64b24ea99753eee99333 100644 (file)
@@ -50,6 +50,7 @@ static int dwc3_exynos_register_phys(struct dwc3_exynos *exynos)
 
        exynos->usb2_phy = pdev;
        pdata.type = USB_PHY_TYPE_USB2;
+       pdata.gpio_reset = -1;
 
        ret = platform_device_add_data(exynos->usb2_phy, &pdata, sizeof(pdata));
        if (ret)
index 665686e7c8cd4342afe150a53dcf3603dac8fe5d..f393c183cc69ddc5431bde705f80b0ea46a7367b 100644 (file)
@@ -52,6 +52,7 @@ static int dwc3_pci_register_phys(struct dwc3_pci *glue)
 
        glue->usb2_phy = pdev;
        pdata.type = USB_PHY_TYPE_USB2;
+       pdata.gpio_reset = -1;
 
        ret = platform_device_add_data(glue->usb2_phy, &pdata, sizeof(pdata));
        if (ret)