sched, thermal: Clean up preempt_enable_no_resched() abuse
authorPeter Zijlstra <peterz@infradead.org>
Wed, 11 Dec 2013 11:21:17 +0000 (12:21 +0100)
committerIngo Molnar <mingo@kernel.org>
Mon, 13 Jan 2014 16:39:18 +0000 (17:39 +0100)
The only valid use of preempt_enable_no_resched() is if the very next
line is schedule() or if we know preemption cannot actually be enabled
by that statement due to known more preempt_count 'refs'.

Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: rjw@rjwysocki.net
Cc: Eliezer Tamir <eliezer.tamir@linux.intel.com>
Cc: rui.zhang@intel.com
Cc: jacob.jun.pan@linux.intel.com
Cc: Mike Galbraith <bitbucket@online.de>
Cc: hpa@zytor.com
Cc: Arjan van de Ven <arjan@linux.intel.com>
Cc: lenb@kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Link: http://lkml.kernel.org/n/tip-zcfvacdlvlr63qmnn5i58vuj@git.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
drivers/thermal/intel_powerclamp.c

index e8275f2df9af9966c38b3e1a73b35c251d949c44..d833c8f5b465d4a96e5ee0d34de8758e1035169e 100644 (file)
@@ -443,7 +443,7 @@ static int clamp_thread(void *arg)
                        atomic_inc(&idle_wakeup_counter);
                }
                tick_nohz_idle_exit();
-               preempt_enable_no_resched();
+               preempt_enable();
        }
        del_timer_sync(&wakeup_timer);
        clear_bit(cpunr, cpu_clamping_mask);