Remove `packageID` parameter from PackageListPage

It's no longer used since the previous commit, badly named and also a security
issue, because it might be used with a XSRF attack.

diff --git a/wcfsetup/install/files/acp/templates/packageList.tpl b/wcfsetup/install/files/acp/templates/packageList.tpl
index 25f22830951f67c6cbcdd67e3ffb4fa33aa7b972..343c02c8b2697b6bdfb5750a475b57a5692c44d7 100644 (file)
--- a/wcfsetup/install/files/acp/templates/packageList.tpl
+++ b/wcfsetup/install/files/acp/templates/packageList.tpl
@@ -13,14 +13,7 @@
                });
                
                {if $__wcf->session->getPermission('admin.configuration.package.canUninstallPackage')}
-                       new WCF.ACP.Package.Uninstallation($('.jsPackageRow .jsUninstallButton'), null);
-                       {if $packageID}
-                               new WCF.PeriodicalExecuter(function(pe) {
-                                       pe.stop();
-                                       $('.jsUninstallButton[data-object-id={@$packageID}]').trigger('click');
-                               }, 250);
-                       {/if}
-                       
+                       new WCF.ACP.Package.Uninstallation($('.jsPackageRow .jsUninstallButton'), null);                        
                        new WCF.ACP.Package.Uninstallation($('.jsPluginContainer .jsUninstallButton'));
                {/if}
                

diff --git a/wcfsetup/install/files/lib/acp/page/PackageListPage.class.php b/wcfsetup/install/files/lib/acp/page/PackageListPage.class.php
index 15ddf40bd78ab731135eaa0666fbb50126b4e7d0..c4625e830a3e9c3744655b843aa9b9eb81aa9d76 100644 (file)
--- a/wcfsetup/install/files/lib/acp/page/PackageListPage.class.php
+++ b/wcfsetup/install/files/lib/acp/page/PackageListPage.class.php
@@ -49,12 +49,6 @@ class PackageListPage extends SortablePage
      */
     public $defaultSortOrder = 'DESC';
 
-    /**
-     * package id for uninstallation
-     * @var int
-     */
-    public $packageID = 0;
-
     /**
      * @inheritDoc
      */
@@ -78,18 +72,6 @@ class PackageListPage extends SortablePage
      */
     public $objectListClassName = PackageList::class;
 
-    /**
-     * @inheritDoc
-     */
-    public function readParameters()
-    {
-        parent::readParameters();
-
-        if (isset($_GET['packageID'])) {
-            $this->packageID = \intval($_GET['packageID']);
-        }
-    }
-
     /**
      * @inheritDoc
      */
@@ -108,7 +90,6 @@ class PackageListPage extends SortablePage
 
         WCF::getTPL()->assign([
             'recentlyDisabledCustomValues' => LanguageFactory::getInstance()->countRecentlyDisabledCustomValues(),
-            'packageID' => $this->packageID,
             'taintedApplications' => $taintedApplications,
             'availableUpgradeVersion' => WCF::AVAILABLE_UPGRADE_VERSION,
             'upgradeOverrideEnabled' => PackageUpdateServer::isUpgradeOverrideEnabled(),