drm/arm: mali-dp: Fix error return code in malidp_bind()

Fix to return error code -EINVAL from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 3c31760e760c ('drm/arm: mali-dp: Set crtc.port to the port
instead of the endpoint')
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Acked-by: Brian Starkey <brian.starkey@arm.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1469672066-13401-1-git-send-email-weiyj.lk@gmail.com

diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
index 116032216e622123c170a382d3321a46aade7f53..82171d223f2d4f469ebfeac54aeba04cab4b015a 100644 (file)
--- a/drivers/gpu/drm/arm/malidp_drv.c
+++ b/drivers/gpu/drm/arm/malidp_drv.c
@@ -360,8 +360,10 @@ static int malidp_bind(struct device *dev)
 
        /* Set the CRTC's port so that the encoder component can find it */
        ep = of_graph_get_next_endpoint(dev->of_node, NULL);
-       if (!ep)
+       if (!ep) {
+               ret = -EINVAL;
                goto port_fail;
+       }
        malidp->crtc.port = of_get_next_parent(ep);
 
        ret = component_bind_all(dev, drm);