bnx2i: use strlcpy() instead of memcpy() for strings

DRV_MODULE_VERSION here is "2.7.2.2" which is only 8 chars but we copy
12 bytes from the stack so it's a small information leak.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Michael Chan <mchan@broadcom.com>
Acked-by: Eddie Wai <eddie.wai@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b/drivers/scsi/bnx2i/bnx2i_init.c
index 7729a5223b339959a841a08d211822d5a7ed4e7b..b17637aab9a792a959558ef79184800f9f0280a2 100644 (file)
--- a/drivers/scsi/bnx2i/bnx2i_init.c
+++ b/drivers/scsi/bnx2i/bnx2i_init.c
@@ -400,7 +400,7 @@ int bnx2i_get_stats(void *handle)
        if (!stats)
                return -ENOMEM;
 
-       memcpy(stats->version, DRV_MODULE_VERSION, sizeof(stats->version));
+       strlcpy(stats->version, DRV_MODULE_VERSION, sizeof(stats->version));
        memcpy(stats->mac_add1 + 2, hba->cnic->mac_addr, ETH_ALEN);
 
        stats->max_frame_size = hba->netdev->mtu;