net: ethernet: wiznet: avoid format string exposure
authorKees Cook <keescook@chromium.org>
Wed, 5 Apr 2017 21:39:35 +0000 (14:39 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 6 Apr 2017 20:38:11 +0000 (13:38 -0700)
While unlikely, this makes sure any format strings in the device name
can't exposure information via the resulting workqueue name.

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/wiznet/w5100.c

index f90267f0519feebb7c9d944535cb81f53c6bb9fe..2bdfb39215e9ce749ecc5fac8f4a22226c081bc4 100644 (file)
@@ -1152,7 +1152,8 @@ int w5100_probe(struct device *dev, const struct w5100_ops *ops,
        if (err < 0)
                goto err_register;
 
-       priv->xfer_wq = alloc_workqueue(netdev_name(ndev), WQ_MEM_RECLAIM, 0);
+       priv->xfer_wq = alloc_workqueue("%s", WQ_MEM_RECLAIM, 0,
+                                       netdev_name(ndev));
        if (!priv->xfer_wq) {
                err = -ENOMEM;
                goto err_wq;