projects / GitHub / exynos8895 / android_kernel_samsung_universal8895.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 1a898a7)
[SCSI] bfa: Fix WARN_ON condition check
authorVijaya Mohan Guvva <vmohan@brocade.com>
Mon, 13 May 2013 09:33:22 +0000 (02:33 -0700)
committerJames Bottomley <JBottomley@Parallels.com>
Wed, 26 Jun 2013 18:45:51 +0000 (11:45 -0700)
The WARN_ON condition check in IO completion path is wrong. IOtags
returned by the firmware is compared with driver/bfa iotag after masking
the retry count bits.

Signed-off-by: Vijaya Mohan Guvva <vmohan@brocade.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/bfa/bfa_fcpim.c patch | blob | blame | history

diff --git a/drivers/scsi/bfa/bfa_fcpim.c b/drivers/scsi/bfa/bfa_fcpim.c
index 27b560962357b7da7ca49d5b2be6660d3d45c429..d7385d1d9c5aeac6d9a62c6069bc45bb969cc719 100644 (file)
--- a/drivers/scsi/bfa/bfa_fcpim.c
+++ b/drivers/scsi/bfa/bfa_fcpim.c
@@ -2882,7 +2882,7 @@ bfa_ioim_good_comp_isr(struct bfa_s *bfa, struct bfi_msg_s *m)
        iotag = be16_to_cpu(rsp->io_tag);
 
        ioim = BFA_IOIM_FROM_TAG(fcpim, iotag);
-       WARN_ON(BFA_IOIM_TAG_2_ID(ioim->iotag) != iotag);
+       WARN_ON(ioim->iotag != iotag);
 
        bfa_ioim_cb_profile_comp(fcpim, ioim);