clocksource/drivers/mtk_timer: Fix memleak in mtk_timer_init()
authorAlexey Klimov <alexey.klimov@linaro.org>
Sun, 25 Oct 2015 23:21:24 +0000 (23:21 +0000)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Tue, 15 Dec 2015 08:41:04 +0000 (09:41 +0100)
Add error path to clear evt struct allocated by kzalloc() in the beginning of
function mtk_timer_init().

Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
drivers/clocksource/mtk_timer.c

index e1e06429734fb353adf5151b7599345468b19704..d67bc356488ffd0590f76abea3c28087c051ffcb 100644 (file)
@@ -205,7 +205,7 @@ static void __init mtk_timer_init(struct device_node *node)
        evt->gpt_base = of_io_request_and_map(node, 0, "mtk-timer");
        if (IS_ERR(evt->gpt_base)) {
                pr_err("Can't get resource\n");
-               return;
+               goto err_kzalloc;
        }
 
        evt->dev.irq = irq_of_parse_and_map(node, 0);
@@ -260,5 +260,7 @@ err_mem:
        iounmap(evt->gpt_base);
        of_address_to_resource(node, 0, &res);
        release_mem_region(res.start, resource_size(&res));
+err_kzalloc:
+       kfree(evt);
 }
 CLOCKSOURCE_OF_DECLARE(mtk_mt6577, "mediatek,mt6577-timer", mtk_timer_init);