staging: r8188eu: remove pxmitbuf parameter of rtl8188eu_xmitframe_complete function
authorIvan Safonov <insafonov@gmail.com>
Sat, 3 Sep 2016 15:31:25 +0000 (22:31 +0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 12 Sep 2016 09:23:22 +0000 (11:23 +0200)
pxmitbuf always is NULL.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c
drivers/staging/rtl8188eu/include/rtl8188e_xmit.h
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c

index ec21d8c82eba535464915c4ea3e8795b90dae75f..88d1dadefcb58e8b5c4553743c55736ae31832e3 100644 (file)
@@ -424,11 +424,12 @@ static u32 xmitframe_need_length(struct xmit_frame *pxmitframe)
        return len;
 }
 
-s32 rtl8188eu_xmitframe_complete(struct adapter *adapt, struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)
+s32 rtl8188eu_xmitframe_complete(struct adapter *adapt, struct xmit_priv *pxmitpriv)
 {
        struct hal_data_8188e   *haldata = GET_HAL_DATA(adapt);
        struct xmit_frame *pxmitframe = NULL;
        struct xmit_frame *pfirstframe = NULL;
+       struct xmit_buf *pxmitbuf;
 
        /*  aggregate variable */
        struct hw_xmit *phwxmit;
@@ -450,12 +451,9 @@ s32 rtl8188eu_xmitframe_complete(struct adapter *adapt, struct xmit_priv *pxmitp
 
        RT_TRACE(_module_rtl8192c_xmit_c_, _drv_info_, ("+xmitframe_complete\n"));
 
-       /*  check xmitbuffer is ok */
-       if (pxmitbuf == NULL) {
-               pxmitbuf = rtw_alloc_xmitbuf(pxmitpriv);
-               if (pxmitbuf == NULL)
-                       return false;
-       }
+       pxmitbuf = rtw_alloc_xmitbuf(pxmitpriv);
+       if (pxmitbuf == NULL)
+               return false;
 
        /* 3 1. pick up first frame */
        rtw_free_xmitframe(pxmitpriv, pxmitframe);
index 65a63df2077f38df4bdfae09669583fde4023aef..97942c5816a531307fcb489fb520b1f338d337ce 100644 (file)
@@ -160,8 +160,7 @@ s32 rtl8188eu_xmit_buf_handler(struct adapter *padapter);
 #define hal_xmit_handler rtl8188eu_xmit_buf_handler
 void rtl8188eu_xmit_tasklet(void *priv);
 s32 rtl8188eu_xmitframe_complete(struct adapter *padapter,
-                                struct xmit_priv *pxmitpriv,
-                                struct xmit_buf *pxmitbuf);
+                                struct xmit_priv *pxmitpriv);
 
 void dump_txrpt_ccx_88e(void *buf);
 void handle_txrpt_ccx_88e(struct adapter *adapter, u8 *buf);
index abb476b8f1c5e74d9a7df35171ca21bc1a4ad74f..7f9fbe94dd1035a9e86b3f02bdf70c86936e47f3 100644 (file)
@@ -848,7 +848,7 @@ void rtl8188eu_xmit_tasklet(void *priv)
                        break;
                }
 
-               ret = rtl8188eu_xmitframe_complete(adapt, pxmitpriv, NULL);
+               ret = rtl8188eu_xmitframe_complete(adapt, pxmitpriv);
 
                if (!ret)
                        break;