net: rds: Remove repeated function names from debug output
authorRasmus Villemoes <linux@rasmusvillemoes.dk>
Thu, 5 Feb 2015 22:17:20 +0000 (23:17 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sun, 8 Feb 2015 06:41:56 +0000 (22:41 -0800)
The macro rdsdebug is defined as

  pr_debug("%s(): " fmt, __func__ , ##args)

Hence it doesn't make sense to include the name of the calling
function explicitly in the format string passed to rdsdebug.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/rds/ib_send.c
net/rds/iw_cm.c
net/rds/iw_send.c

index 1dde91e3dc7033c575dcfc041a23402f98e52239..bd3825d38abc923bd905b6af266b4fffe706f427 100644 (file)
@@ -409,7 +409,7 @@ try_again:
        posted = IB_GET_POST_CREDITS(oldval);
        avail = IB_GET_SEND_CREDITS(oldval);
 
-       rdsdebug("rds_ib_send_grab_credits(%u): credits=%u posted=%u\n",
+       rdsdebug("wanted=%u credits=%u posted=%u\n",
                        wanted, avail, posted);
 
        /* The last credit must be used to send a credit update. */
@@ -453,7 +453,7 @@ void rds_ib_send_add_credits(struct rds_connection *conn, unsigned int credits)
        if (credits == 0)
                return;
 
-       rdsdebug("rds_ib_send_add_credits(%u): current=%u%s\n",
+       rdsdebug("credits=%u current=%u%s\n",
                        credits,
                        IB_GET_SEND_CREDITS(atomic_read(&ic->i_credits)),
                        test_bit(RDS_LL_SEND_FULL, &conn->c_flags) ? ", ll_send_full" : "");
index a91e1db62ee6a1833e65372989b0644d980899e6..a6c2bea9f8f9b37b46ce381336a90fb685187083 100644 (file)
@@ -590,8 +590,8 @@ void rds_iw_conn_shutdown(struct rds_connection *conn)
                        /* Actually this may happen quite frequently, when
                         * an outgoing connect raced with an incoming connect.
                         */
-                       rdsdebug("rds_iw_conn_shutdown: failed to disconnect,"
-                                  " cm: %p err %d\n", ic->i_cm_id, err);
+                       rdsdebug("failed to disconnect, cm: %p err %d\n",
+                                ic->i_cm_id, err);
                }
 
                if (ic->i_cm_id->qp) {
index 9105ea03aec5dc05bad0221eb00c4794eb6e463a..13834780a3089e9e640e470f7b2e8b26c6334b7b 100644 (file)
@@ -361,7 +361,7 @@ try_again:
        posted = IB_GET_POST_CREDITS(oldval);
        avail = IB_GET_SEND_CREDITS(oldval);
 
-       rdsdebug("rds_iw_send_grab_credits(%u): credits=%u posted=%u\n",
+       rdsdebug("wanted=%u credits=%u posted=%u\n",
                        wanted, avail, posted);
 
        /* The last credit must be used to send a credit update. */
@@ -405,7 +405,7 @@ void rds_iw_send_add_credits(struct rds_connection *conn, unsigned int credits)
        if (credits == 0)
                return;
 
-       rdsdebug("rds_iw_send_add_credits(%u): current=%u%s\n",
+       rdsdebug("credits=%u current=%u%s\n",
                        credits,
                        IB_GET_SEND_CREDITS(atomic_read(&ic->i_credits)),
                        test_bit(RDS_LL_SEND_FULL, &conn->c_flags) ? ", ll_send_full" : "");