drm/shmob: Drop drm_vblank_cleanup
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 21 Jun 2017 08:28:46 +0000 (10:28 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 22 Jun 2017 06:41:15 +0000 (08:41 +0200)
It doesn't do anything in the driver load error paths that the drm
core doesn't also do (cleanup is done in drm_dev_fini).

Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170621082850.13224-10-daniel.vetter@ffwll.ch
drivers/gpu/drm/shmobile/shmob_drm_drv.c

index 800d1d2c435d0b7e4954728afc4d4bee9bae58cb..c2ca07357aac5d731e864360977b839406a9aff8 100644 (file)
@@ -277,7 +277,7 @@ static int shmob_drm_probe(struct platform_device *pdev)
        ret = drm_irq_install(ddev, platform_get_irq(pdev, 0));
        if (ret < 0) {
                dev_err(&pdev->dev, "failed to install IRQ handler\n");
-               goto err_vblank_cleanup;
+               goto err_modeset_cleanup;
        }
 
        /*
@@ -292,8 +292,6 @@ static int shmob_drm_probe(struct platform_device *pdev)
 
 err_irq_uninstall:
        drm_irq_uninstall(ddev);
-err_vblank_cleanup:
-       drm_vblank_cleanup(ddev);
 err_modeset_cleanup:
        drm_kms_helper_poll_fini(ddev);
        drm_mode_config_cleanup(ddev);