drm/i915: Unifiy GT powersave suspend logic
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 12 Jun 2014 15:48:52 +0000 (17:48 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 12 Jun 2014 16:24:18 +0000 (18:24 +0200)
Jesse's patch to only quiescent our rps work and Imre's fix to address
a race with runtime pm and the forcewake reference held by the used
diverging means to address the same bug: Jesse's patch uses
flush_delayed_work while (since we want to make sure rps is set up)
while Imre's used a cancel+manuel refcount adjustment.

Unify them again by simply reusing intel_suspend_gt_powersave in
intel_disable_gt_powersave.

Cc: Imre Deak <imre.deak@intel.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_pm.c

index 685b4910eb930a70c4ad102e0b3afddf6c0f7215..49122204a001611231925666cb522b39fafedcd5 100644 (file)
@@ -4706,10 +4706,8 @@ void intel_disable_gt_powersave(struct drm_device *dev)
                ironlake_disable_drps(dev);
                ironlake_disable_rc6(dev);
        } else if (IS_GEN6(dev) || IS_GEN7(dev) || IS_BROADWELL(dev)) {
-               if (cancel_delayed_work_sync(&dev_priv->rps.delayed_resume_work))
-                       intel_runtime_pm_put(dev_priv);
+               intel_suspend_gt_powersave(dev);
 
-               cancel_work_sync(&dev_priv->rps.work);
                mutex_lock(&dev_priv->rps.hw_lock);
                if (IS_VALLEYVIEW(dev))
                        valleyview_disable_rps(dev);