iwlwifi: mvm: don't return uninitialized value in get_survey()
authorJohannes Berg <johannes.berg@intel.com>
Wed, 1 Apr 2015 08:00:31 +0000 (10:00 +0200)
committerEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Thu, 2 Apr 2015 06:29:12 +0000 (09:29 +0300)
If ucode_loaded isn't true the function returns the 'ret' variable
without having assigned a value properly. Fix that.

Reported-by: Haim Dreyfuss <haim.dreyfuss@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
drivers/net/wireless/iwlwifi/mvm/mac80211.c

index fc73cc1bda0d2cf681ff1325ff560eb84a820ce1..74912e7fd3b2863701b287efa8de0e8a7fd3a57c 100644 (file)
@@ -3911,6 +3911,7 @@ static int iwl_mvm_mac_get_survey(struct ieee80211_hw *hw, int idx,
                            mvm->radio_stats.on_time_scan;
        do_div(survey->time_scan, USEC_PER_MSEC);
 
+       ret = 0;
  out:
        mutex_unlock(&mvm->mutex);
        return ret;