staging: sm750fb: remove unneeded switch statement
authorMike Rapoport <mike.rapoport@gmail.com>
Thu, 1 Oct 2015 09:14:02 +0000 (12:14 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 2 Oct 2015 09:50:52 +0000 (11:50 +0200)
The lynxfb_ops_check_var function has two switch statements, the first
one checks for validity of var->bits_per_pixel and it is is immediatly
followed by another one that sets parameters according to
var->bits_per_pixel value. These switch statements can be merged into
one.

Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/sm750fb/sm750.c

index 81fe3c3266d524d54d60c86e3dbe77d5bcc999eb..4d261d56105313f33bbd527faa59808039b92ba0 100644 (file)
@@ -537,18 +537,6 @@ static int lynxfb_ops_check_var(struct fb_var_screeninfo *var,
                 var->yres,
                 var->bits_per_pixel);
 
-       switch (var->bits_per_pixel) {
-       case 8:
-       case 16:
-       case 24: /* support 24 bpp for only lynx712/722/720 */
-       case 32:
-               break;
-       default:
-               pr_err("bpp %d not supported\n", var->bits_per_pixel);
-               ret = -EINVAL;
-               goto exit;
-       }
-
        switch (var->bits_per_pixel) {
        case 8:
                info->fix.visual = FB_VISUAL_PSEUDOCOLOR;
@@ -583,8 +571,8 @@ static int lynxfb_ops_check_var(struct fb_var_screeninfo *var,
                info->fix.visual = FB_VISUAL_TRUECOLOR;
                break;
        default:
-               ret = -EINVAL;
-               break;
+               pr_err("bpp %d not supported\n", var->bits_per_pixel);
+               return -EINVAL;
        }
        var->height = var->width = -1;
        var->accel_flags = 0;/* FB_ACCELF_TEXT; */
@@ -603,7 +591,6 @@ static int lynxfb_ops_check_var(struct fb_var_screeninfo *var,
        ret = output->proc_checkMode(output, var);
        if (!ret)
                ret = crtc->proc_checkMode(crtc, var);
-exit:
        return ret;
 }