fs: warn about impending deprecation of mandatory locks
authorJeff Layton <jlayton@kernel.org>
Fri, 20 Aug 2021 13:29:50 +0000 (09:29 -0400)
committerSasha Levin <sashal@kernel.org>
Thu, 26 Aug 2021 12:37:29 +0000 (08:37 -0400)
[ Upstream commit fdd92b64d15bc4aec973caa25899afd782402e68 ]

We've had CONFIG_MANDATORY_FILE_LOCKING since 2015 and a lot of distros
have disabled it. Warn the stragglers that still use "-o mand" that
we'll be dropping support for that mount option.

Cc: stable@vger.kernel.org
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/namespace.c

index 68457fa2f981d10fc868ad899affdab07ebd0b84..b9e30a385c0135d671d528f0d4008482a60eb766 100644 (file)
@@ -1670,8 +1670,12 @@ static inline bool may_mount(void)
 }
 
 #ifdef CONFIG_MANDATORY_FILE_LOCKING
-static inline bool may_mandlock(void)
+static bool may_mandlock(void)
 {
+       pr_warn_once("======================================================\n"
+                    "WARNING: the mand mount option is being deprecated and\n"
+                    "         will be removed in v5.15!\n"
+                    "======================================================\n");
        return capable(CAP_SYS_ADMIN);
 }
 #else