mmc: sdhci: Report failure reasons for all cases in sdhci_add_host()
authorMark Brown <broonie@opensource.wolfsonmicro.com>
Mon, 2 Jul 2012 13:26:15 +0000 (14:26 +0100)
committerChris Ball <cjb@laptop.org>
Sun, 22 Jul 2012 19:25:45 +0000 (15:25 -0400)
For most error conditions sdhci_add_host() will print a diagnostic
message indicating why it failed but there are a few cases where this
does not happen. Add error messages in these cases to aid diagnosis.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Chris Ball <cjb@laptop.org>
drivers/mmc/host/sdhci.c

index 206b52fec44351d38ff457b207e204af1046ed02..101f9d43196f6b033621e2d0463c9ce9eb17a058 100644 (file)
@@ -3033,8 +3033,11 @@ int sdhci_add_host(struct sdhci_host *host)
 
        ret = request_irq(host->irq, sdhci_irq, IRQF_SHARED,
                mmc_hostname(mmc), host);
-       if (ret)
+       if (ret) {
+               pr_err("%s: Failed to request IRQ %d: %d\n",
+                      mmc_hostname(mmc), host->irq, ret);
                goto untasklet;
+       }
 
        sdhci_init(host, 0);
 
@@ -3051,8 +3054,11 @@ int sdhci_add_host(struct sdhci_host *host)
        host->led.brightness_set = sdhci_led_control;
 
        ret = led_classdev_register(mmc_dev(mmc), &host->led);
-       if (ret)
+       if (ret) {
+               pr_err("%s: Failed to register LED device: %d\n",
+                      mmc_hostname(mmc), ret);
                goto reset;
+       }
 #endif
 
        mmiowb();