[media] tda18271-common: Convert _tda_printk to return void
authorJoe Perches <joe@perches.com>
Mon, 22 Sep 2014 17:50:35 +0000 (14:50 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Tue, 23 Sep 2014 20:03:59 +0000 (17:03 -0300)
No caller or macro uses the return value so make it void.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/tuners/tda18271-common.c
drivers/media/tuners/tda18271-priv.h

index 18c77afe2e4ff8f32345a56d6aae199de1062c74..86e5e31101186ef37b30055b9f43e0725fc7ba01 100644 (file)
@@ -714,12 +714,11 @@ fail:
        return ret;
 }
 
-int _tda_printk(struct tda18271_priv *state, const char *level,
-               const char *func, const char *fmt, ...)
+void _tda_printk(struct tda18271_priv *state, const char *level,
+                const char *func, const char *fmt, ...)
 {
        struct va_format vaf;
        va_list args;
-       int rtn;
 
        va_start(args, fmt);
 
@@ -727,15 +726,13 @@ int _tda_printk(struct tda18271_priv *state, const char *level,
        vaf.va = &args;
 
        if (state)
-               rtn = printk("%s%s: [%d-%04x|%c] %pV",
-                            level, func, i2c_adapter_id(state->i2c_props.adap),
-                            state->i2c_props.addr,
-                            (state->role == TDA18271_MASTER) ? 'M' : 'S',
-                            &vaf);
+               printk("%s%s: [%d-%04x|%c] %pV",
+                      level, func, i2c_adapter_id(state->i2c_props.adap),
+                      state->i2c_props.addr,
+                      (state->role == TDA18271_MASTER) ? 'M' : 'S',
+                      &vaf);
        else
-               rtn = printk("%s%s: %pV", level, func, &vaf);
+               printk("%s%s: %pV", level, func, &vaf);
 
        va_end(args);
-
-       return rtn;
 }
index 454c152ccaa023d66423591108ca16616c058660..b36a7b75477253ad6cc1e678579833d8476354fb 100644 (file)
@@ -139,8 +139,8 @@ extern int tda18271_debug;
 #define DBG_CAL  16
 
 __attribute__((format(printf, 4, 5)))
-int _tda_printk(struct tda18271_priv *state, const char *level,
-               const char *func, const char *fmt, ...);
+void _tda_printk(struct tda18271_priv *state, const char *level,
+                const char *func, const char *fmt, ...);
 
 #define tda_printk(st, lvl, fmt, arg...)                       \
        _tda_printk(st, lvl, __func__, fmt, ##arg)