gpio: sysfs: fix memory leak in gpiod_export_link
authorJohan Hovold <johan@kernel.org>
Mon, 26 Jan 2015 11:02:45 +0000 (12:02 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 30 Jan 2015 09:28:27 +0000 (10:28 +0100)
Fix memory leak in the gpio sysfs interface due to failure to drop
reference to device returned by class_find_device when creating a link.

Fixes: a4177ee7f1a8 ("gpiolib: allow exported GPIO nodes to be named
using sysfs links")
Cc: stable <stable@vger.kernel.org> # v2.6.32
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpiolib-sysfs.c

index f62aa115d79ab4f9fe7e249dbb146dfdde44153e..4667830f350e77e55e7d15bef38aaf0db27f63bd 100644 (file)
@@ -648,6 +648,7 @@ int gpiod_export_link(struct device *dev, const char *name,
                if (tdev != NULL) {
                        status = sysfs_create_link(&dev->kobj, &tdev->kobj,
                                                name);
+                       put_device(tdev);
                } else {
                        status = -ENODEV;
                }