econet: Use sock_orphan() instead of open-coded (and buggy) variant.
authorDavid S. Miller <davem@davemloft.net>
Tue, 17 Jun 2008 10:01:47 +0000 (03:01 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 17 Jun 2008 10:01:47 +0000 (03:01 -0700)
It doesn't grab the sk_callback_lock, it doesn't NULL out
the sk->sk_sleep waitqueue pointer, etc.

Signed-off-by: David S. Miller <davem@davemloft.net>
net/econet/af_econet.c

index 7c9bb13b1539daf0e31465a31a41b0282fd429dd..d35127bb84e1cf99b83c86dca44311f7841010d6 100644 (file)
@@ -573,9 +573,7 @@ static int econet_release(struct socket *sock)
 
        sk->sk_state_change(sk);        /* It is useless. Just for sanity. */
 
-       sock->sk = NULL;
-       sk->sk_socket = NULL;
-       sock_set_flag(sk, SOCK_DEAD);
+       sock_orphan(sk);
 
        /* Purge queues */