qed: Replace memset with eth_zero_addr
authorShyam Saini <mayhs11saini@gmail.com>
Tue, 17 Jan 2017 02:05:04 +0000 (07:35 +0530)
committerDavid S. Miller <davem@davemloft.net>
Tue, 17 Jan 2017 20:24:47 +0000 (15:24 -0500)
Use eth_zero_addr to assign zero address to the given address array
instead of memset when the second argument in memset is address
of zero. Also, it makes the code clearer

Signed-off-by: Shyam Saini <mayhs11saini@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qed/qed_l2.c
drivers/net/ethernet/qlogic/qed/qed_sriov.c

index c92a8506c1e1641179882daf96224234f0fa4beb..7520eb34ad007f4e81cd6c653fb339c9d4bf6a61 100644 (file)
@@ -1846,7 +1846,7 @@ static int qed_fill_eth_dev_info(struct qed_dev *cdev,
        qed_fill_dev_info(cdev, &info->common);
 
        if (IS_VF(cdev))
-               memset(info->common.hw_mac, 0, ETH_ALEN);
+               eth_zero_addr(info->common.hw_mac);
 
        return 0;
 }
index b1213643bbfdd95a21c0b9624c396fe832d1facb..3f4bf31f45e0acc4846d0d6e02b7397f18cf88f0 100644 (file)
@@ -1224,7 +1224,7 @@ static void qed_iov_clean_vf(struct qed_hwfn *p_hwfn, u8 vfid)
                return;
 
        /* Clear the VF mac */
-       memset(vf_info->mac, 0, ETH_ALEN);
+       eth_zero_addr(vf_info->mac);
 
        vf_info->rx_accept_mode = 0;
        vf_info->tx_accept_mode = 0;
@@ -2626,8 +2626,7 @@ static int qed_iov_vf_update_mac_shadow(struct qed_hwfn *p_hwfn,
                for (i = 0; i < QED_ETH_VF_NUM_MAC_FILTERS; i++) {
                        if (ether_addr_equal(p_vf->shadow_config.macs[i],
                                             p_params->mac)) {
-                               memset(p_vf->shadow_config.macs[i], 0,
-                                      ETH_ALEN);
+                               eth_zero_addr(p_vf->shadow_config.macs[i]);
                                break;
                        }
                }
@@ -2640,7 +2639,7 @@ static int qed_iov_vf_update_mac_shadow(struct qed_hwfn *p_hwfn,
        } else if (p_params->opcode == QED_FILTER_REPLACE ||
                   p_params->opcode == QED_FILTER_FLUSH) {
                for (i = 0; i < QED_ETH_VF_NUM_MAC_FILTERS; i++)
-                       memset(p_vf->shadow_config.macs[i], 0, ETH_ALEN);
+                       eth_zero_addr(p_vf->shadow_config.macs[i]);
        }
 
        /* List the new MAC address */