ARM: 9078/1: Add warn suppress parameter to arm_gen_branch_link()

commit 890cb057a46d323fd8c77ebecb6485476614cd21 upstream

Will be used in the following patch. No functional change.

Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/arch/arm/include/asm/insn.h b/arch/arm/include/asm/insn.h
index e96065da4daebe8347f6dab3da2f3ba542ac320b..0043bf609f271c9df2cebe5a02166a4e384657dc 100644 (file)
--- a/arch/arm/include/asm/insn.h
+++ b/arch/arm/include/asm/insn.h
@@ -12,18 +12,18 @@ arm_gen_nop(void)
 }
 
 unsigned long
-__arm_gen_branch(unsigned long pc, unsigned long addr, bool link);
+__arm_gen_branch(unsigned long pc, unsigned long addr, bool link, bool warn);
 
 static inline unsigned long
 arm_gen_branch(unsigned long pc, unsigned long addr)
 {
-       return __arm_gen_branch(pc, addr, false);
+       return __arm_gen_branch(pc, addr, false, true);
 }
 
 static inline unsigned long
-arm_gen_branch_link(unsigned long pc, unsigned long addr)
+arm_gen_branch_link(unsigned long pc, unsigned long addr, bool warn)
 {
-       return __arm_gen_branch(pc, addr, true);
+       return __arm_gen_branch(pc, addr, true, warn);
 }
 
 #endif

diff --git a/arch/arm/kernel/ftrace.c b/arch/arm/kernel/ftrace.c
index 414e60ed02573d06af2a94ac576cdd75df027d11..a95bc0a02fd8046e848043a3cde4e12ec3d0f0ae 100644 (file)
--- a/arch/arm/kernel/ftrace.c
+++ b/arch/arm/kernel/ftrace.c
@@ -97,7 +97,7 @@ int ftrace_arch_code_modify_post_process(void)
 
 static unsigned long ftrace_call_replace(unsigned long pc, unsigned long addr)
 {
-       return arm_gen_branch_link(pc, addr);
+       return arm_gen_branch_link(pc, addr, true);
 }
 
 static int ftrace_modify_code(unsigned long pc, unsigned long old,

diff --git a/arch/arm/kernel/insn.c b/arch/arm/kernel/insn.c
index b760340b70146123bd05dbc32e47d042f8d243d1..eaded01b7edfc694d04514216472244b21aaeacd 100644 (file)
--- a/arch/arm/kernel/insn.c
+++ b/arch/arm/kernel/insn.c
@@ -2,8 +2,9 @@
 #include <linux/kernel.h>
 #include <asm/opcodes.h>
 
-static unsigned long
-__arm_gen_branch_thumb2(unsigned long pc, unsigned long addr, bool link)
+static unsigned long __arm_gen_branch_thumb2(unsigned long pc,
+                                            unsigned long addr, bool link,
+                                            bool warn)
 {
        unsigned long s, j1, j2, i1, i2, imm10, imm11;
        unsigned long first, second;
@@ -11,7 +12,7 @@ __arm_gen_branch_thumb2(unsigned long pc, unsigned long addr, bool link)
 
        offset = (long)addr - (long)(pc + 4);
        if (offset < -16777216 || offset > 16777214) {
-               WARN_ON_ONCE(1);
+               WARN_ON_ONCE(warn);
                return 0;
        }
 
@@ -32,8 +33,8 @@ __arm_gen_branch_thumb2(unsigned long pc, unsigned long addr, bool link)
        return __opcode_thumb32_compose(first, second);
 }
 
-static unsigned long
-__arm_gen_branch_arm(unsigned long pc, unsigned long addr, bool link)
+static unsigned long __arm_gen_branch_arm(unsigned long pc, unsigned long addr,
+                                         bool link, bool warn)
 {
        unsigned long opcode = 0xea000000;
        long offset;
@@ -43,7 +44,7 @@ __arm_gen_branch_arm(unsigned long pc, unsigned long addr, bool link)
 
        offset = (long)addr - (long)(pc + 8);
        if (unlikely(offset < -33554432 || offset > 33554428)) {
-               WARN_ON_ONCE(1);
+               WARN_ON_ONCE(warn);
                return 0;
        }
 
@@ -53,10 +54,10 @@ __arm_gen_branch_arm(unsigned long pc, unsigned long addr, bool link)
 }
 
 unsigned long
-__arm_gen_branch(unsigned long pc, unsigned long addr, bool link)
+__arm_gen_branch(unsigned long pc, unsigned long addr, bool link, bool warn)
 {
        if (IS_ENABLED(CONFIG_THUMB2_KERNEL))
-               return __arm_gen_branch_thumb2(pc, addr, link);
+               return __arm_gen_branch_thumb2(pc, addr, link, warn);
        else
-               return __arm_gen_branch_arm(pc, addr, link);
+               return __arm_gen_branch_arm(pc, addr, link, warn);
 }