genirq/cpuhotplug: Remove irq disabling logic
authorThomas Gleixner <tglx@linutronix.de>
Mon, 19 Jun 2017 23:37:25 +0000 (01:37 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Thu, 22 Jun 2017 16:21:16 +0000 (18:21 +0200)
This is called from stop_machine() with interrupts disabled. No point in
disabling them some more.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Keith Busch <keith.busch@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>
Link: http://lkml.kernel.org/r/20170619235445.198042748@linutronix.de
kernel/irq/cpuhotplug.c

index 011f8c4c63da056cad5bb7ac575ff740192dd76e..7051398315900db6dadbe1d7ecf3a596a05cd146 100644 (file)
@@ -59,11 +59,8 @@ static bool migrate_one_irq(struct irq_desc *desc)
  */
 void irq_migrate_all_off_this_cpu(void)
 {
-       unsigned int irq;
        struct irq_desc *desc;
-       unsigned long flags;
-
-       local_irq_save(flags);
+       unsigned int irq;
 
        for_each_active_irq(irq) {
                bool affinity_broken;
@@ -73,10 +70,9 @@ void irq_migrate_all_off_this_cpu(void)
                affinity_broken = migrate_one_irq(desc);
                raw_spin_unlock(&desc->lock);
 
-               if (affinity_broken)
-                       pr_warn_ratelimited("IRQ%u no longer affine to CPU%u\n",
+               if (affinity_broken) {
+                       pr_warn_ratelimited("IRQ %u: no longer affine to CPU%u\n",
                                            irq, smp_processor_id());
+               }
        }
-
-       local_irq_restore(flags);
 }