ASoC: mxs-saif: Handle return value of clk_prepare_enable/clk_prepare.
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Tue, 25 Jul 2017 10:14:33 +0000 (15:44 +0530)
committerMark Brown <broonie@kernel.org>
Wed, 26 Jul 2017 12:00:56 +0000 (13:00 +0100)
clk_prepare_enable() and clk_prepare() can fail here and
we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/mxs/mxs-saif.c

index b42f301c6b960490d9392902e16e1dbbf78045a7..156aa7c00787860b1f26267ffcf4267601433acf 100644 (file)
@@ -125,7 +125,9 @@ static int mxs_saif_set_clk(struct mxs_saif *saif,
         *
         * If MCLK is not used, we just set saif clk to 512*fs.
         */
-       clk_prepare_enable(master_saif->clk);
+       ret = clk_prepare_enable(master_saif->clk);
+       if (ret)
+               return ret;
 
        if (master_saif->mclk_in_use) {
                switch (mclk / rate) {
@@ -388,6 +390,7 @@ static int mxs_saif_startup(struct snd_pcm_substream *substream,
                           struct snd_soc_dai *cpu_dai)
 {
        struct mxs_saif *saif = snd_soc_dai_get_drvdata(cpu_dai);
+       int ret;
 
        /* clear error status to 0 for each re-open */
        saif->fifo_underrun = 0;
@@ -401,7 +404,9 @@ static int mxs_saif_startup(struct snd_pcm_substream *substream,
        __raw_writel(BM_SAIF_CTRL_CLKGATE,
                saif->base + SAIF_CTRL + MXS_CLR_ADDR);
 
-       clk_prepare(saif->clk);
+       ret = clk_prepare(saif->clk);
+       if (ret)
+               return ret;
 
        return 0;
 }
@@ -468,7 +473,9 @@ static int mxs_saif_hw_params(struct snd_pcm_substream *substream,
                if (ret)
                        return ret;
 
-               clk_prepare(master_saif->clk);
+               ret = clk_prepare(master_saif->clk);
+               if (ret)
+                       return ret;
        }
 
        scr = __raw_readl(saif->base + SAIF_CTRL);