ipvs: Delete an unnecessary check before the function call "module_put"
authorMarkus Elfring <elfring@users.sourceforge.net>
Fri, 10 Jul 2015 06:42:49 +0000 (15:42 +0900)
committerPablo Neira Ayuso <pablo@netfilter.org>
Wed, 15 Jul 2015 15:51:22 +0000 (17:51 +0200)
The module_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/ipvs/ip_vs_sched.c

index 199760c71f3995f88dbe73b159906cf7840cdded..e50221b9d95f87fb7d39144c923a6e722e64ca12 100644 (file)
@@ -137,7 +137,7 @@ struct ip_vs_scheduler *ip_vs_scheduler_get(const char *sched_name)
 
 void ip_vs_scheduler_put(struct ip_vs_scheduler *scheduler)
 {
-       if (scheduler && scheduler->module)
+       if (scheduler)
                module_put(scheduler->module);
 }