dmaengine: Move dma_get_slave_caps() implementation to dmaengine.c
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Tue, 28 Oct 2014 22:30:58 +0000 (00:30 +0200)
committerVinod Koul <vinod.koul@intel.com>
Sun, 18 Jan 2015 14:25:57 +0000 (19:55 +0530)
The function is too big to be a static inline.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/dmaengine.c
include/linux/dmaengine.h

index 30211f9791b771560e82f7ca807df34b3902f09c..f15712f2fec6c06949c23f845eeb8bbb776b8907 100644 (file)
@@ -479,6 +479,39 @@ static void dma_channel_rebalance(void)
                }
 }
 
+int dma_get_slave_caps(struct dma_chan *chan, struct dma_slave_caps *caps)
+{
+       struct dma_device *device;
+
+       if (!chan || !caps)
+               return -EINVAL;
+
+       device = chan->device;
+
+       /* check if the channel supports slave transactions */
+       if (!test_bit(DMA_SLAVE, device->cap_mask.bits))
+               return -ENXIO;
+
+       /*
+        * Check whether it reports it uses the generic slave
+        * capabilities, if not, that means it doesn't support any
+        * kind of slave capabilities reporting.
+        */
+       if (!device->directions)
+               return -ENXIO;
+
+       caps->src_addr_widths = device->src_addr_widths;
+       caps->dst_addr_widths = device->dst_addr_widths;
+       caps->directions = device->directions;
+       caps->residue_granularity = device->residue_granularity;
+
+       caps->cmd_pause = !!device->device_pause;
+       caps->cmd_terminate = !!device->device_terminate_all;
+
+       return 0;
+}
+EXPORT_SYMBOL_GPL(dma_get_slave_caps);
+
 static struct dma_chan *private_candidate(const dma_cap_mask_t *mask,
                                          struct dma_device *dev,
                                          dma_filter_fn fn, void *fn_param)
index 6d34ce91036ca872bdfe5501a5c569ba522c5439..1b4842bb3890f0f7bba53e3ad1741e05dfc70278 100644 (file)
@@ -758,37 +758,7 @@ static inline struct dma_async_tx_descriptor *dmaengine_prep_dma_sg(
                        src_sg, src_nents, flags);
 }
 
-static inline int dma_get_slave_caps(struct dma_chan *chan, struct dma_slave_caps *caps)
-{
-       struct dma_device *device;
-
-       if (!chan || !caps)
-               return -EINVAL;
-
-       device = chan->device;
-
-       /* check if the channel supports slave transactions */
-       if (!test_bit(DMA_SLAVE, device->cap_mask.bits))
-               return -ENXIO;
-
-       /*
-        * Check whether it reports it uses the generic slave
-        * capabilities, if not, that means it doesn't support any
-        * kind of slave capabilities reporting.
-        */
-       if (!device->directions)
-               return -ENXIO;
-
-       caps->src_addr_widths = device->src_addr_widths;
-       caps->dst_addr_widths = device->dst_addr_widths;
-       caps->directions = device->directions;
-       caps->residue_granularity = device->residue_granularity;
-
-       caps->cmd_pause = !!device->device_pause;
-       caps->cmd_terminate = !!device->device_terminate_all;
-
-       return 0;
-}
+int dma_get_slave_caps(struct dma_chan *chan, struct dma_slave_caps *caps);
 
 static inline int dmaengine_terminate_all(struct dma_chan *chan)
 {