staging: comedi: remove redundant pointer dereference in comedi_poll()
authorIan Abbott <abbotti@mev.co.uk>
Fri, 2 May 2014 12:50:13 +0000 (13:50 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 4 May 2014 00:12:17 +0000 (20:12 -0400)
`s->async->subdevice` in `comedi_poll()` points to the same `struct
comedi_subdevice` as `s`, so the double pointer reference is redundant.
Just use `s`.

(`s->async->subdevice` is initialized by
`__comedi_device_postconfig_async()` in
"drivers/staging/comedi/drivers.c" and doesn't change.)

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/comedi_fops.c

index b24bf9bcbe2d400350a6f268dd7fecb27a7889a9..ecd27a6fc7f9692b9b8a0fe1f669ff6b36e0ae00 100644 (file)
@@ -2035,7 +2035,7 @@ static unsigned int comedi_poll(struct file *file, poll_table *wait)
 
        s = comedi_write_subdevice(dev, minor);
        if (s && s->async) {
-               unsigned int bps = bytes_per_sample(s->async->subdevice);
+               unsigned int bps = bytes_per_sample(s);
 
                poll_wait(file, &s->async->wait_head, wait);
                comedi_buf_write_alloc(s->async, s->async->prealloc_bufsz);