bridge: Avoid 'statement with no effect' compiler warnings
authorLee Jones <lee.jones@linaro.org>
Sat, 3 Nov 2012 22:02:30 +0000 (23:02 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sun, 4 Nov 2012 05:59:29 +0000 (01:59 -0400)
Instead of issuing (0) statements when !CONFIG_SYSFS which will cause
'warning: ', we'll use inline statements instead. This will effectively
do the same thing, but suppress any unnecessary warnings.

Cc: Stephen Hemminger <shemminger@vyatta.com>
Cc: bridge@lists.linux-foundation.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/br_private.h

index d5efa57a2c20bc2863b56baa8b5f71e55d607fa5..22111ffd68dffa8cbb4ed2acb73179ce4b196495 100644 (file)
@@ -570,10 +570,10 @@ extern void br_sysfs_delbr(struct net_device *dev);
 
 #else
 
-#define br_sysfs_addif(p)      (0)
-#define br_sysfs_renameif(p)   (0)
-#define br_sysfs_addbr(dev)    (0)
-#define br_sysfs_delbr(dev)    do { } while(0)
+static inline int br_sysfs_addif(struct net_bridge_port *p) { return 0; }
+static inline int br_sysfs_renameif(struct net_bridge_port *p) { return 0; }
+static inline int br_sysfs_addbr(struct net_device *dev) { return 0; }
+static inline void br_sysfs_delbr(struct net_device *dev) { return; }
 #endif /* CONFIG_SYSFS */
 
 #endif