xfs: remove XBF_READ flag wrapper macros
authorDave Chinner <dchinner@redhat.com>
Wed, 10 Feb 2016 04:01:11 +0000 (15:01 +1100)
committerDave Chinner <david@fromorbit.com>
Wed, 10 Feb 2016 04:01:11 +0000 (15:01 +1100)
They only set/clear/check a flag, no need for obfuscating this
with a macro.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/xfs_buf.h
fs/xfs/xfs_log_recover.c

index 2a28d1ccbfb936b009a51ab939cb4f6335f6b3a7..329e612460a6c366de2d8965aa7acf103d418508 100644 (file)
@@ -321,10 +321,6 @@ void xfs_buf_stale(struct xfs_buf *bp);
 #define XFS_BUF_UNSTALE(bp)    ((bp)->b_flags &= ~XBF_STALE)
 #define XFS_BUF_ISSTALE(bp)    ((bp)->b_flags & XBF_STALE)
 
-#define XFS_BUF_READ(bp)       ((bp)->b_flags |= XBF_READ)
-#define XFS_BUF_UNREAD(bp)     ((bp)->b_flags &= ~XBF_READ)
-#define XFS_BUF_ISREAD(bp)     ((bp)->b_flags & XBF_READ)
-
 #define XFS_BUF_WRITE(bp)      ((bp)->b_flags |= XBF_WRITE)
 #define XFS_BUF_UNWRITE(bp)    ((bp)->b_flags &= ~XBF_WRITE)
 #define XFS_BUF_ISWRITE(bp)    ((bp)->b_flags & XBF_WRITE)
index f00cce9bf830fa1e987c59a17c9d5943034345fa..e747bad5b64e1004e026d33d30627e0377424ef8 100644 (file)
@@ -190,7 +190,7 @@ xlog_bread_noalign(
        ASSERT(nbblks <= bp->b_length);
 
        XFS_BUF_SET_ADDR(bp, log->l_logBBstart + blk_no);
-       XFS_BUF_READ(bp);
+       bp->b_flags |= XBF_READ;
        bp->b_io_length = nbblks;
        bp->b_error = 0;
 
@@ -4928,7 +4928,7 @@ xlog_do_recover(
        bp = xfs_getsb(log->l_mp, 0);
        bp->b_flags &= ~(XBF_DONE | XBF_ASYNC);
        ASSERT(!(XFS_BUF_ISWRITE(bp)));
-       XFS_BUF_READ(bp);
+       bp->b_flags |= XBF_READ;
        bp->b_ops = &xfs_sb_buf_ops;
 
        error = xfs_buf_submit_wait(bp);