mellanox: Change en_print to return void
authorJoe Perches <joe@perches.com>
Mon, 22 Sep 2014 17:40:22 +0000 (10:40 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 26 Sep 2014 19:17:16 +0000 (15:17 -0400)
No caller or macro uses the return value so make it void.

Signed-off-by: Joe Perches <joe@perches.com>
Acked-By: Amir Vadai <amirv@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx4/en_main.c
drivers/net/ethernet/mellanox/mlx4/mlx4_en.h

index 3626fdf4cb5ddd491d82b3e3496bfd8994546b0e..2091ae88615d3fde397da0e1e04f442c96012483 100644 (file)
@@ -78,27 +78,24 @@ MLX4_EN_PARM_INT(inline_thold, MAX_INLINE,
 #define MAX_PFC_TX     0xff
 #define MAX_PFC_RX     0xff
 
-int en_print(const char *level, const struct mlx4_en_priv *priv,
-            const char *format, ...)
+void en_print(const char *level, const struct mlx4_en_priv *priv,
+             const char *format, ...)
 {
        va_list args;
        struct va_format vaf;
-       int i;
 
        va_start(args, format);
 
        vaf.fmt = format;
        vaf.va = &args;
        if (priv->registered)
-               i = printk("%s%s: %s: %pV",
-                          level, DRV_NAME, priv->dev->name, &vaf);
+               printk("%s%s: %s: %pV",
+                      level, DRV_NAME, priv->dev->name, &vaf);
        else
-               i = printk("%s%s: %s: Port %d: %pV",
-                          level, DRV_NAME, dev_name(&priv->mdev->pdev->dev),
-                          priv->port, &vaf);
+               printk("%s%s: %s: Port %d: %pV",
+                      level, DRV_NAME, dev_name(&priv->mdev->pdev->dev),
+                      priv->port, &vaf);
        va_end(args);
-
-       return i;
 }
 
 void mlx4_en_update_loopback_state(struct net_device *dev,
index e3d71c386da71a34efaf334bbb02d3a3276427fe..6a4fc2394cf2df9487e507e55bef7279b7b5c1eb 100644 (file)
@@ -842,8 +842,8 @@ extern const struct ethtool_ops mlx4_en_ethtool_ops;
  */
 
 __printf(3, 4)
-int en_print(const char *level, const struct mlx4_en_priv *priv,
-            const char *format, ...);
+void en_print(const char *level, const struct mlx4_en_priv *priv,
+             const char *format, ...);
 
 #define en_dbg(mlevel, priv, format, ...)                              \
 do {                                                                   \