GFS2: Fix glock ref counting bug
authorSteven Whitehouse <swhiteho@redhat.com>
Thu, 30 Apr 2009 13:52:58 +0000 (14:52 +0100)
committerSteven Whitehouse <swhiteho@redhat.com>
Sat, 9 May 2009 14:15:17 +0000 (15:15 +0100)
Depending on the ordering of events as we go around the
glock shrinker loop, it is possible to drop the ref count
of a glock incorrectly. It doesn't happen very often. This
patch corrects the got_ref variable, fixing the problem.

Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
fs/gfs2/glock.c

index 1afd9f26bcb118287bf008355439ea8aba5597fc..ff49810904897788465263af146bcb1ead719567 100644 (file)
@@ -1304,6 +1304,7 @@ static int gfs2_shrink_glock_memory(int nr, gfp_t gfp_mask)
                                nr--;
                                if (queue_delayed_work(glock_workqueue, &gl->gl_work, 0) == 0)
                                        gfs2_glock_put(gl);
+                               got_ref = 0;
                        }
                        spin_lock(&lru_lock);
                        if (may_demote)