perf coresight: Remove superfluous check before use
authorKim Phillips <kim.phillips@arm.com>
Thu, 15 Jun 2017 17:55:21 +0000 (12:55 -0500)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 19 Jun 2017 18:27:08 +0000 (15:27 -0300)
The cs_etm_evsel variable is guaranteed to be set at this point in
cs_etm_recording_options().

Signed-off-by: Kim Phillips <kim.phillips@arm.com>
Acked-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: linux-arm-kernel@lists.infradead.org
Link: http://lkml.kernel.org/r/20170615125521.80cc128dc856bc1f2e61b730@arm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/arch/arm/util/cs-etm.c

index 02a649bfec3c69bc5414361321367514ddd8dd6f..7ce3d1a2513378b5e0ec8d01040364d6ddc3b5a6 100644 (file)
@@ -203,19 +203,18 @@ static int cs_etm_recording_options(struct auxtrace_record *itr,
                pr_debug2("%s snapshot size: %zu\n", CORESIGHT_ETM_PMU_NAME,
                          opts->auxtrace_snapshot_size);
 
-       if (cs_etm_evsel) {
-               /*
-                * To obtain the auxtrace buffer file descriptor, the auxtrace
-                * event must come first.
-                */
-               perf_evlist__to_front(evlist, cs_etm_evsel);
-               /*
-                * In the case of per-cpu mmaps, we need the CPU on the
-                * AUX event.
-                */
-               if (!cpu_map__empty(cpus))
-                       perf_evsel__set_sample_bit(cs_etm_evsel, CPU);
-       }
+       /*
+        * To obtain the auxtrace buffer file descriptor, the auxtrace
+        * event must come first.
+        */
+       perf_evlist__to_front(evlist, cs_etm_evsel);
+
+       /*
+        * In the case of per-cpu mmaps, we need the CPU on the
+        * AUX event.
+        */
+       if (!cpu_map__empty(cpus))
+               perf_evsel__set_sample_bit(cs_etm_evsel, CPU);
 
        /* Add dummy event to keep tracking */
        if (opts->full_auxtrace) {