ARM: tegra20: MC: Remove unnecessary BUG*()
authorHiroshi DOYU <hdoyu@nvidia.com>
Fri, 11 May 2012 10:04:44 +0000 (13:04 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 11 May 2012 22:21:27 +0000 (15:21 -0700)
Accessing interleaved MC register offsets/ranges are verified. BUG*()s
in accessors can be removed.

Signed-off-by: Hiroshi DOYU <hdoyu@nvidia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/memory/tegra20-mc.c

index c0bfffacdc64c7ea570fd0b5ba947f2e4328aed2..2a437e92756c1e86d33ff4cdf93570f0937d15ea 100644 (file)
@@ -53,12 +53,14 @@ struct tegra20_mc {
 
 static inline u32 mc_readl(struct tegra20_mc *mc, u32 offs)
 {
+       u32 val = 0;
+
        if (offs < 0x24)
-               return readl(mc->regs[0] + offs);
-       BUG_ON(offs < 0x3c);
+               val = readl(mc->regs[0] + offs);
        if (offs < 0x400)
-               return readl(mc->regs[1] + offs - 0x3c);
-       BUG();
+               val = readl(mc->regs[1] + offs - 0x3c);
+
+       return val;
 }
 
 static inline void mc_writel(struct tegra20_mc *mc, u32 val, u32 offs)
@@ -67,12 +69,10 @@ static inline void mc_writel(struct tegra20_mc *mc, u32 val, u32 offs)
                writel(val, mc->regs[0] + offs);
                return;
        }
-       BUG_ON(offs < 0x3c);
        if (offs < 0x400) {
                writel(val, mc->regs[1] + offs - 0x3c);
                return;
        }
-       BUG();
 }
 
 static const char * const tegra20_mc_client[] = {