staging: silicom: fix a comparing proc_dir_entry pointer against 0
authorDevendra Naga <devendra.aaru@gmail.com>
Sun, 16 Sep 2012 16:01:59 +0000 (12:01 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Sep 2012 12:31:33 +0000 (05:31 -0700)
we should be using the NULL macro, not 0 to compare against
a pointer value, and also remove braces around the single
if conditional after the create_proc_entry

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/silicom/bp_mod.c

index f138d29752952006b32228d0102e507dc0231009..2722da91dea39e413fa6a50b497d2b3a56014d13 100644 (file)
@@ -7725,10 +7725,8 @@ bypass_proc_create_entry_sd(struct pfs_unit_sd *pfs_unit_curr,
                                                      S_IFREG | S_IRUSR |
                                                      S_IWUSR | S_IRGRP |
                                                      S_IROTH, parent_pfs);
-       if (pfs_unit_curr->proc_entry == 0) {
-
+       if (pfs_unit_curr->proc_entry == NULL)
                return -1;
-       }
 
        pfs_unit_curr->proc_entry->read_proc = read_proc;
        pfs_unit_curr->proc_entry->write_proc = write_proc;