reiserfs: use proper little-endian bitops
authorAkinobu Mita <akinobu.mita@gmail.com>
Tue, 26 Jul 2011 00:13:37 +0000 (17:13 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 26 Jul 2011 03:57:17 +0000 (20:57 -0700)
Using __test_and_{set,clear}_bit_le() with ignoring its return value can
be replaced with __{set,clear}_bit_le().

This introduces reiserfs_{set,clear}_le_bit for __{set,clear}_bit_le and
does the above change with them.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/reiserfs/bitmap.c
fs/reiserfs/resize.c
include/linux/reiserfs_fs.h

index 483442e66ed6d2066869fa770ec63c6808a3b283..567385aa7813f114c4a9cc64bf8aa59e4b7e4c2c 100644 (file)
@@ -214,7 +214,7 @@ static int scan_bitmap_block(struct reiserfs_transaction_handle *th,
                                        }
                                        /* otherwise we clear all bit were set ... */
                                        while (--i >= *beg)
-                                               reiserfs_test_and_clear_le_bit
+                                               reiserfs_clear_le_bit
                                                    (i, bh->b_data);
                                        reiserfs_restore_prepared_buffer(s, bh);
                                        *beg = org;
index b3a94d20f0fcd37b044596369687a7d1cebfa2f5..b6b9b1fe33b057c864ca146af150565c11de585c 100644 (file)
@@ -136,7 +136,7 @@ int reiserfs_resize(struct super_block *s, unsigned long block_count_new)
                                return -EIO;
                        }
                        memset(bh->b_data, 0, sb_blocksize(sb));
-                       reiserfs_test_and_set_le_bit(0, bh->b_data);
+                       reiserfs_set_le_bit(0, bh->b_data);
                        reiserfs_cache_bitmap_metadata(s, bh, bitmap + i);
 
                        set_buffer_uptodate(bh);
@@ -172,7 +172,7 @@ int reiserfs_resize(struct super_block *s, unsigned long block_count_new)
 
        reiserfs_prepare_for_journal(s, bh, 1);
        for (i = block_r; i < s->s_blocksize * 8; i++)
-               reiserfs_test_and_clear_le_bit(i, bh->b_data);
+               reiserfs_clear_le_bit(i, bh->b_data);
        info->free_count += s->s_blocksize * 8 - block_r;
 
        journal_mark_dirty(&th, s, bh);
@@ -190,7 +190,7 @@ int reiserfs_resize(struct super_block *s, unsigned long block_count_new)
 
        reiserfs_prepare_for_journal(s, bh, 1);
        for (i = block_r_new; i < s->s_blocksize * 8; i++)
-               reiserfs_test_and_set_le_bit(i, bh->b_data);
+               reiserfs_set_le_bit(i, bh->b_data);
        journal_mark_dirty(&th, s, bh);
        brelse(bh);
 
index eca75df00fedd54d95b7448ab9099764519de7e8..96d465f8d3e6441ca19cdea54bfd7b12edbd4b05 100644 (file)
@@ -2332,7 +2332,9 @@ __u32 keyed_hash(const signed char *msg, int len);
 __u32 yura_hash(const signed char *msg, int len);
 __u32 r5_hash(const signed char *msg, int len);
 
+#define reiserfs_set_le_bit            __set_bit_le
 #define reiserfs_test_and_set_le_bit   __test_and_set_bit_le
+#define reiserfs_clear_le_bit          __clear_bit_le
 #define reiserfs_test_and_clear_le_bit __test_and_clear_bit_le
 #define reiserfs_test_le_bit           test_bit_le
 #define reiserfs_find_next_zero_le_bit find_next_zero_bit_le